[vlc-devel] commit: Do not notifications actions if the server does not support it ( Cody Russell )

Rémi Denis-Courmont rem at videolan.org
Wed Feb 25 18:05:00 CET 2009


Le mercredi 25 février 2009 18:41:28 Laurent Aimar, vous avez écrit :
>  This is not thread safe (unless I missed a global lock somewhere).
> It would probably be better to store it inside p_intf->p_sys instead.

It is called with the lock, but indeed it's not global. That would be a 
problem if we have more than one notify plugin instance in the process. That 
seems to not be supported by libnotify anyhow. I don't really know though.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary



More information about the vlc-devel mailing list