[vlc-devel] [PATCH] bug in globalhotkeys

[Sébastien Escudier]

Quoting Sébastien Escudier <sebastien-devel at celeos.eu>:

> I don't see any case where it doesn't work. If the handler I restore is not
> valid anymore, it is not vlc's responsibility

Ho I think I see what you meant.
The previous handler may not have been unregistered because vlc changed it.

Another solution could be to not use XSetErrorHandler.
I am quoting :
http://www.motifdeveloper.com/tips/tip29.html

This means that an application program can use the routine to temporarily
override Xlib error behavior, installing its own handler for a given purpose,
and then later re-install the default handler when some critical piece of code
is finished.

This is not the way it is used in this module.