[vlc-devel] [PATCH] Dynamic Overlay :: Fixed settextcolor

[basos g]

2008/12/31 Doug West <mdwest at gmail.com>:
> The video filter dynamicoverlay function SetTextColor does not appear to set
> the colors properly. However, if you edit the file
> dynamicoverlay_commands.c, and change line 272 from:
>
> p_params->fontstyle.i_font_color = (r<<24) | (g<<16) | (b<<8);
>
> to:
>
> p_params->fontstyle.i_font_color = (r<<16) | (g<<8) | b;
>
> The colors appear to set properly.
>
> I don't know if this is what should be done to correct the problem I saw, or
> I just didn't understand how to use the SetTextColor function properly. But,
> since this worked for me and the way I thought SetTextColor should work, I
> thought I'd pass the information along.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
>

Indeed
Patch included

Colors are in RRGGBB format as stated in vlc_osd.h
int        i_outline_color;   /**< The color of the outline 0xRRGGBB */
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Dynamic-Overlay-Fixed-settextcolor.patch
Type: text/x-diff
Size: 2071 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090108/a02b2907/attachment.patch>