[vlc-devel] [PATCH] Added a performance check to marquee filter

Antoine Cellerier dionoea at videolan.org
Fri Jan 9 13:57:05 CET 2009

On Fri, Jan 09, 2009, basos g wrote:
> We preparse format string for the special case of user wanting to
> print % , so passing %%, marking the string as unchanged to avoid
> unneeded calls to time() and localtime()

A better idea might be to add an extra argument (like bool pointer) to
the 2 format string related functions in the VLC core and set it to
false if no valid format was detected. That way modules themselves don't
have to know how the format string functions work internaly. (of course
the vlc core doesn't know how strftime works either)


Antoine Cellerier

More information about the vlc-devel mailing list