[vlc-devel] commit: Small code factorization ( Rémi Denis-Courmont )

[Michael Hanselmann]

On Sat, Jan 10, 2009 at 2:07 PM, git version control <git at videolan.org> wrote:
> diff --git a/src/modules/os.c b/src/modules/os.c
> index 38df5e7..997e780 100644
> --- a/src/modules/os.c
> +++ b/src/modules/os.c
> @@ -213,27 +213,21 @@ int module_Load( vlc_object_t *p_this, const char *psz_file,
> +# if defined (RTLD_NOW)
> +    const int flags = RTLD_NOW;
> +# elif defined (DL_LAZY)
> +    const int flags = DL_LAZY;
> +# else
> +    const int flags = 0;
> +# endif
>
> -#elif defined(HAVE_DL_DLOPEN)
> -#   if defined(DL_LAZY)
> -    handle = dlopen( psz_file, DL_LAZY );
> -#   else
> -    handle = dlopen( psz_file, 0 );
> -#   endif
> +    handle = dlopen( psz_file, RTLD_NOW );
>     if( handle == NULL )

Shouldn't it have been "dlopen( psz_file, flags )"?

Regards,
Michael