[vlc-devel] [PATCH] Global Hotkeys for windows

Hannes Domani ssbssa at yahoo.de
Thu Jan 15 16:58:03 CET 2009

--- Rémi Denis-Courmont <rem at videolan.org> wrote on Do, 15.1.2009:
> If CreateWindow() fails, Close() will perform an invalid
> PostMessage(). I 
> don't know Win32 API well enough, and this might not be
> an issue.
I will check that.

> But I don't understand why you're creating a window handle in the
> first place instead of 
> using the thread message queue.
RegisterHotKey() needs a window handle which it sends the WM_HOTKEY messages.

> Also, there's no need to add parenthesis after
> 'return'.
I know, but I always do it that way.

> Finally, it might be simpler to register the action rather
> than the variable 
> name in the atom?
So I don't need the asprintf() in the Unregistering part any more? Didn't see that. Will change it.

Domani Hannes


More information about the vlc-devel mailing list