[vlc-devel] [PATCH] Taglib: undefined operation de to duplicate usage of var with post-increment

Dominique Leuenberger dominique at leuenberger.net
Sat Jan 17 17:05:30 CET 2009


On Sat, 2009-01-17 at 17:39 +0200, Rémi Denis-Courmont wrote:
> Le samedi 17 janvier 2009 17:32:45 Dominique Leuenberger, vous avez écrit :
> > demux_t* p_demux, demux_meta_t* int max_size = p_ufid->identifier().size()
> > < 63 ?
> >                             p_ufid->identifier().size() : 63;
> >              while( j < max_size )
> > -                psz_ufid[j] = p_ufid->identifier()[j++];
> > +                psz_ufid[j] = p_ufid->identifier()[j];
> > +                j++;
> >              psz_ufid[j] = '\0';
> >              vlc_meta_SetTrackID( p_meta, psz_ufid );
> >          }
> 
> Come on, this is C, not Python.
> 

Ok.. with some help I might have understood this remark now... 
I give it another try.

Updated patch attached. (thanks ogg.k !)

Dominique
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Taglib-undefined-operation-de-to-duplicate-usage-of.patch
Type: text/x-patch
Size: 1331 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090117/875a6129/attachment.bin>


More information about the vlc-devel mailing list