[vlc-devel] [PATCH] Allow more than one hotkey per action

Antoine Cellerier dionoea at videolan.org
Fri Jan 23 10:06:07 CET 2009


On Fri, Jan 23, 2009, Rémi Denis-Courmont wrote:
> You mean preference dialogs, right? Generating hotkeys event should not
> need to change, nor should waiting for action, since the mapping is
> centralized in the core as of 0.9.

Everything currently assumes that you have 1 hotkey per action. That
part wasn't the one that needed most change though. The impacting change
in my patch is making the configuration options accept a list of hotkeys
instead of a single hotkey.

> Makes me wonder if we shouldn't flip the configuration the other way round:
> key -> action, rather than action -> key. That would match sound more
> logical and avoid the list altogether.

Flipping it in the prefs doesn't sound doable. You'd need to have 1 pref
entry per possible key combo.

I'm going to try the other approach I mentioned tonight and see if it
looks better (but I'm afraid that it'll imply lots of constant reparsing
of the hotkey config values in the different interface's preference
code).

-- 
Antoine Cellerier
dionoea



More information about the vlc-devel mailing list