[vlc-devel] [PATCH] Allow more than one hotkey per action

Laurent Aimar fenrir at via.ecp.fr
Fri Jan 23 10:17:02 CET 2009


On Fri, Jan 23, 2009, Jean-Baptiste Kempf wrote:
> On Fri, Jan 23, 2009 at 09:38:04AM +0100, Laurent Aimar wrote :
> > Hi,
> > 
> > On Fri, Jan 23, 2009, Rémi Denis-Courmont wrote:
> > > On Thu, 22 Jan 2009 23:44:56 +0100, Antoine Cellerier
> > > Makes me wonder if we shouldn't flip the configuration the other way round:
> > > key -> action, rather than action -> key. That would match sound more
> > > logical and avoid the list altogether.
> >  I agree with that.
> >  The downside I see is complete breakage of old conf regarding this issue, but
> > if done before 1.0, I find it acceptable.
> >  Another good think with it, is that it would probably be very easy to add
> > mouse->action mapping then :)
> > 
> >  Becarefull that it will at least break lirc (module and configuration file).
> 
> Will win32 global_hotkey still work?
 If we have a:
 - key-a for normal key 'a'
 - global-key-a for global key 'a'
 If think it will work as before.

The problem I see now, is the number of config entry needed, something like:
 numbers_of_keys * 2 ^ number_of_modifiers

It will be a lot: 96 * 2^5 = 3072 (*2 for global, and plus 5 * 2^5 four complete mouse events)

-- 
fenrir



More information about the vlc-devel mailing list