[vlc-devel] [PATCH] Allow more than one hotkey per action

Rémi Denis-Courmont rdenis at simphalempin.com
Fri Jan 23 13:15:01 CET 2009

On Fri, 23 Jan 2009 10:06:07 +0100, Antoine Cellerier
<dionoea at videolan.org> wrote:
> Everything currently assumes that you have 1 hotkey per action. That
> part wasn't the one that needed most change though. The impacting change
> in my patch is making the configuration options accept a list of hotkeys
> instead of a single hotkey.

Duh? Anything not configuration-related that needs to know about _both_
actions and hotkeys is broken. Plugins getting hotkey events from the
system should only set hotkeys, and plugins registering for actions should
only get actions. That's why we have the mapping done in core now.

>> Makes me wonder if we shouldn't flip the configuration the other way
> round:
>> key -> action, rather than action -> key. That would match sound more
>> logical and avoid the list altogether.
> Flipping it in the prefs doesn't sound doable. You'd need to have 1 pref
> entry per possible key combo.

So what? There are 3 modifiers and a bit over a hundred keys. A table of a
thousand pointers is just one memory page.

Rémi Denis-Courmont

More information about the vlc-devel mailing list