[vlc-devel] [PATCH] -- persistence for main window in qt4

[Vicente Jiménez]

Sorry, I'll try to explain it better.
I just was wondering if is better to activate this feature with just
"--keep-size" option without any mention to the specific interface.
If is a useful feature, I suppose is a must have in ANY interface.
I think is better to have it as an option an say that for now it only
works with Qt interface than create one option for each interface.


> On Sat, Jan 24, 2009 at 1:27 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> On Sat, Jan 24, 2009 at 01:14:19AM +0100, Vicente Jiménez wrote :
>>> Rename --qt-keep-size to --keep-size?
>> Sorry? I don't get the question...
>>
>>  '--qt-keep-size' is cool. But that doesn't answer the remarks on the
>>  patch.
>>
>>
>>> On Sat, Jan 24, 2009 at 12:50 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>> > On Sat, Jan 24, 2009 at 12:39:50AM +0100, brezhoneg1 wrote :
>>> >> This patch is an attempt to save/restore qt4 main window size and
>>> >> confine video within this predefined resizeable window.
>>> >> It is not meant to replace the current behaviour (where windows expand
>>> >> to fit original video size) but rather to come as an alternative. For
>>> >> that purpose, a --qt-keep-size has been created.
>>> >
>>> > This is very wanted, yes.
>>> >
>>> >> This is a working patch (tested on Ubuntu7.10).
>>> >
>>> > 1) Could you avoid calling config_GetInt( p_intf, "qt-keep-size" ) every
>>> > other line? Especially in such a critical function that sizeHint() is?
>>> > Store it in MainInterface at construction or something similar.
>>> >
>>> > 2) Could you simplify a bit the code of sizeHint() ? Do you really need
>>> > this switch ?
>>> >
>>> > 3) Setting a value in QSeting during resizeHint() and accessing it in
>>> > sizeHint() is not a good solution for the same reason as 1).
>>> > Please change.
>>> >
>>> >
>>> > Best Regards,
>>> >
>>> > --
>>> > Jean-Baptiste Kempf
>>> > http://www.jbkempf.com/
>>> > _______________________________________________
>>> > vlc-devel mailing list
>>> > To unsubscribe or modify your subscription options:
>>> > http://mailman.videolan.org/listinfo/vlc-devel
>>> >
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> http://mailman.videolan.org/listinfo/vlc-devel
>>
>> --
>> Best Regards,
>>
>> --
>> Jean-Baptiste Kempf
>> http://www.jbkempf.com/
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
>>
>