[vlc-devel] [PATCH] -- persistence for main window in qt4
brezhoneg1 at yahoo.fr
Sat Jan 24 13:18:39 CET 2009
Please, find attached an updated version for this patch with remarks
taken into account.
> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Jean-Baptiste Kempf
> Envoyé : samedi 24 janvier 2009 00:50
> À : Mailing list for VLC media player developers
> Objet : Re: [vlc-devel] [PATCH] -- persistence for main window in qt4
> On Sat, Jan 24, 2009 at 12:39:50AM +0100, brezhoneg1 wrote :
> > This patch is an attempt to save/restore qt4 main window size and
> > confine video within this predefined resizeable window.
> > It is not meant to replace the current behaviour (where windows
> > to fit original video size) but rather to come as an alternative.
> > that purpose, a --qt-keep-size has been created.
> This is very wanted, yes.
> > This is a working patch (tested on Ubuntu7.10).
> 1) Could you avoid calling config_GetInt( p_intf, "qt-keep-size" )
> other line? Especially in such a critical function that sizeHint() is?
> Store it in MainInterface at construction or something similar.
> 2) Could you simplify a bit the code of sizeHint() ? Do you really
> this switch ?
> 3) Setting a value in QSeting during resizeHint() and accessing it in
> sizeHint() is not a good solution for the same reason as 1).
> Please change.
> Best Regards,
> Jean-Baptiste Kempf
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 9312 bytes
Desc: not available
More information about the vlc-devel