[vlc-devel] commit: vlc_savecancel: missing return value on main thread ( Rémi Denis-Courmont )

git version control git at videolan.org
Tue Jan 27 16:44:45 CET 2009


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Tue Jan 27 17:42:17 2009 +0200| [6ce34a21bc23c87c6d4b0b37f798a16ce8bd93d7] | committer: Rémi Denis-Courmont 

vlc_savecancel: missing return value on main thread

We return true to pass killable assertion in vlc_restorecancel()

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6ce34a21bc23c87c6d4b0b37f798a16ce8bd93d7
---

 src/misc/threads.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/misc/threads.c b/src/misc/threads.c
index bcc647a..56096b2 100644
--- a/src/misc/threads.c
+++ b/src/misc/threads.c
@@ -843,7 +843,7 @@ int vlc_savecancel (void)
 #else
     vlc_cancel_t *nfo = vlc_threadvar_get (&cancel_key);
     if (nfo == NULL)
-        return; /* Main thread - cannot be cancelled anyway */
+        return true; /* Main thread - cannot be cancelled anyway */
 
      state = nfo->killable;
      nfo->killable = false;




More information about the vlc-devel mailing list