[vlc-devel] RE : [PATCH] -- scaling activation/deactivation

[brezhoneg1]

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Rémi Denis-Courmont
> Envoyé : mardi 27 janvier 2009 17:19
> À : vlc-devel at videolan.org
> Objet : Re: [vlc-devel] RE : [PATCH] -- scaling
activation/deactivation
> 
> Le mardi 27 janvier 2009 16:44:50 brezhoneg1, vous avez écrit :
> > Actually, changing scaling at run time is not really compatible with
> > some vout-filters (especially wall), leading to crash.
> >
> > The attached patch just deactivates the feature if vout-filter is
used.
> >
> > For other filters (vout2-filter and sub-filter), I have not seen any
> > problems (though, I did not test all of them!)
> 
> Users won't understand why this works sometimes on note others, and it
> sounds
> scary. IMHO, I'd rather remove it completely until this is fixed.
> 

This update solves the vout-filter issue and a small video artefact with
the previous version.

With this patch, "scaling" mimics exactly "crop" and "aspect-ratio"
processing.
- the VOUT_SCALE_CHANGE flag is revived.
- job is done in the vout plugins
- vout-filter special design (a chain of vouts) is taken into account

Attachments consists of :
- patch 1  : core implementation + x11 support
- patch 2  : windows support
- patch 3  : opengl support
- patch 4  : sdl support

Remarks / TODO list :
- patch 2 (Windows) could not be tested.
- Mac is not implemented (if a Mac developer reads this page, ...)
- Opengl is kind of broken (ends up in core dump independent of this
patch see valgrind)


Erwan10
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-scaling-toggle-updated.patch
Type: application/octet-stream
Size: 2678 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090128/767dbaf3/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-scaling-toggle-support-for-windows-not-yet-tested.patch
Type: application/octet-stream
Size: 3405 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090128/767dbaf3/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-scaling-toggle-support-for-opengl-a-bug-correction.patch
Type: application/octet-stream
Size: 2528 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090128/767dbaf3/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-scaling-toggle-support-for-sdl.patch
Type: application/octet-stream
Size: 947 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090128/767dbaf3/attachment-0003.obj>