[vlc-devel] [PATCH] 1: sicne modules/demux/real.c has changed, the realvideo.c

[Rémi Denis-Courmont]

	Hello,

Good overall, but a few comments...

Le samedi 31 janvier 2009 10:51:58 Wang Bo, vous avez écrit :
>  #ifdef WIN32
> -    g_decode_path="plugins\\drv43260.dll";
> +    static const char psz_paths[MAX_PATH*3] = "";

Do we really need 'static' here? If so, a lock is probably required.

> @@ -272,6 +334,8 @@ static int InitVideo(decoder_t *p_dec)
>          "/usr/lib64/RealPlayer10/codecs\0"
>          "/usr/lib64/RealPlayer10GOLD/codecs\0"
>          "/usr/local/lib/codecs\0"
> +        ".\0"
> +        "codecs\0"
>          "\0"
>      };
>

I do not like to look for executable code in the current directory. We have 
already had a CVE entry because of that.

Thanks for your effort,

-- 
Rémi Denis-Courmont