[vlc-devel] [PATCH] Cosmetics : Added some cast in ts.c to prevent warnings
Jean-Baptiste Besnard
jbbesnard at actech-innovation.com
Thu Jul 2 15:50:15 CEST 2009
You're right, I've now changed the type of the two locals variables in
ParsePES to size_t instead of casting them multiple times.
Still removes the negative uint8_t comparison " p_src->i_teletext_type
< 0" in PMTSetupEsTeletext
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Changing-i_pes_size-and-i_skip-type-in-ParsePES-to-a.patch
Type: application/octet-stream
Size: 2212 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090702/87c2aa18/attachment.obj>
-------------- next part --------------
> Le 2 juil. 09 ? 15:02, R?mi Denis-Courmont a ?crit :
> Le jeudi 2 juillet 2009 14:51:47 Jean-Baptiste Besnard, vous avez
> ?crit :
>> Here are some new casts in ./modules/demux/ts.s mainly about
>> signedness.
>
> I do not know that code any better than you do (really), but it
> looks a bit
> backward. Probably the variables type should have their type changed
> to size_t
> or unsigned, rather than be cast, unless they really can take
> negative values.
>
> --
> R?mi Denis-Courmont
> http://www.remlab.net/
>
>
More information about the vlc-devel
mailing list