[vlc-devel] [PATCH]win32 color fix

[Kaarlo Räihä]

Paul Fernquist kirjoitti 02.07.2009 kello 21:13:
> Kaarlo Räihä says:
> > Paul Fernquist kirjoitti 02.07.2009 kello 12:02:
> > > 
> > > I am new and submitted a patch for bad colors in win32. It turns out
> > >  I was
> > > way off. I was patching code thinking the code was Direct3D and VLC was
> > > using the very old DirectDraw library. I switched to Direct3D and
> > >  everything
> > > worked fine. For some reason the Dierct3D module checks for OS
> > >  Version and
> > > rejects everything below Vista OS. Microsoft discourages checking OS
> > >  version
> > > for determining if a feature is present. My XP SP3 system works fine
> > 
> > It doesn't check if the feature is present, it just makes Direct3D default
> video output
> > if OS is Vista or newer, and this is because DirectX (default in other
> Windows versios) disables Aero.
> 
> The OS and DirectX are independent (except DirectX 10 will not be
>  ported to
> XP)
> 
> If you want to use Aero you should check for Aero and don't use Aero
>  if not
> available. Not using Direct3D at all forces the use of the extremely old
> DirectDraw. DirectDraw is obsolete and DirectDraw features are being
> removed.

DirectDraw support won't vanish (there is too much software using it). But there will be Direct2D coming out later if you want to write DirectDraw like software using new API http://en.wikipedia.org/wiki/Direct2D

Also DirectDraw is lighter for GPUs than Direct3D (there are Win2k users that have Riva TNT 2 display adapters or even older ones) and allows use of Overlay which is nice if you TV-out in Theater mode (ATI) or mirroring (NVIDIA).

> 
> What command line option overrides the default?

--vout direct3d

> 
> Thanks,
> Paul Fernquist
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


...................................................................
Luukku Plus paketilla pääset eroon tila- ja turvallisuusongelmista.
Hanki Luukku Plus ja helpotat elämääsi. http://www.mtv3.fi/luukku