[vlc-devel] [PATCH] libvlc API: Add equalizer to audio.c

[Rémi Denis-Courmont]

Le lundi 6 juillet 2009 11:11:57 Cyril MATHE, vous avez écrit :
> Hello,
>
> This patch adds new feature to audio.c : equalizer.
>
> libvlc_audio_set_eqz_enable(int b_enable): enable or disable equalizer
> libvlc_audio_set_eqz_preset(int i_preset): set an equalizer preset
> libvlc_audio_set_eqz(libvlc_audio_eqz_t eqz): set an equalizer
> libvlc_audio_get_eqz_preset(int i_preset): get an equalizer preset
> libvlc_audio_get_eqz(): get current equalizer

The asprintf() error handling looks broken to me. Also, I am increasingly wary 
of merging non-persistent setters/getters, as it means more work for whoever 
fixes them (not unlikely me).

-- 
Rémi Denis-Courmont
http://www.remlab.net/