[vlc-devel] [PATCH] libvlc API: Add equalizer to audio.c

[Pierre d'Herbemont]

On Mon, Jul 6, 2009 at 1:11 AM, Cyril MATHE<cmathe at actech-innovation.com> wrote:
> Hello,
>
> This patch adds new feature to audio.c : equalizer.
>
> libvlc_audio_set_eqz_enable(int b_enable): enable or disable equalizer
> libvlc_audio_set_eqz_preset(int i_preset): set an equalizer preset
> libvlc_audio_set_eqz(libvlc_audio_eqz_t eqz): set an equalizer
> libvlc_audio_get_eqz_preset(int i_preset): get an equalizer preset
> libvlc_audio_get_eqz(): get current equalizer

I don't really like the fact that there is one structure, and multiple
non obvious functions.

There should be only one set/get_eqz and no set/get_eqz_blabl or no
set_eqz and multiple set_eqz_blabla.

The structure shouldn't have type prefix for the members as well.

Can all the functions be justified? Should the naming be more obvious?

I haven't looked at the implementation, but I also like to see persistence.

Pierre.