[vlc-devel] commit: skins2: For Linux, correct files that cannot be loaded because of a workaround that only makes sense on Windows . (Erwan Tulou )

Laurent Aimar fenrir at via.ecp.fr
Fri Jul 10 15:34:00 CEST 2009


On Fri, Jul 10, 2009, git version control wrote:
> vlc | branch: 1.0-bugfix | Erwan Tulou <erwan10 at videolan.org> | Fri Jul 10 14:07:12 2009 +0200| [ff9295b51d2c735b29e64606e007aef18e38d135] | committer: Erwan Tulou 
> 
> skins2: For Linux, correct files that cannot be loaded because of a workaround that only makes sense on Windows.
> 
> Forcefully setting a file name with lower case was inserted to solve an issue that is only true on Windows. On Linux, upper/lower case must not be tampered with.
 If the following comment is correct, then I think that your fix is not valid.

> -                // Convert to lower case because of some buggy winamp2 skins
>                  string name = m_name + "." + section + "." + var;
> +
> +#ifdef WIN32
> +                // Convert to lower case because of some buggy winamp2 skins
>                  for( size_t i=0; i< name.size(); i++)
>                  {
>                      name[i] = tolower( name[i] );
>                  }
> +#endif
 I can load winamp skins under linux...

-- 
fenrir



More information about the vlc-devel mailing list