[vlc-devel] RE : commit: skins2: For Linux, correct files that cannot be loaded because of a workaround thatonly makes sense on Windows . (Erwan Tulou )

[brezhoneg1]

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de brezhoneg Breizh
> Envoyé : vendredi 10 juillet 2009 16:40
> À : Mailing list for VLC media player developers
> Objet : [vlc-devel] Re : commit: skins2: For Linux,correct files that
> cannot be loaded because of a workaround thatonly makes sense on
Windows .
> (Erwan Tulou )
> 
> 
> > skins2: For Linux, correct files that cannot be loaded because of a
> workaround that only makes sense on Windows.
> >
> > Forcefully setting a file name with lower case was inserted to solve
an
> issue that is only true on Windows. On Linux, upper/lower case must
not be
> tampered with.
> If the following comment is correct, then I think that your fix is not
> valid.
> 
> > -                // Convert to lower case because of some buggy
winamp2
> skins
> >                  string name = m_name + "." + section + "." + var;
> > +
> > +#ifdef WIN32
> > +                // Convert to lower case because of some buggy
winamp2
> skins
> >                  for( size_t i=0; i< name.size(); i++)
> >                  {
> >                      name[i] = tolower( name[i] );
> >                  }
> > +#endif
> 


I tried to find a winamp2 skins2 that requires the workaround and could
not find one on the skins website. Is this workaround still useful?

On the other hand, it limits new skins to never using any upper case
characters in filenames, which skins developers are obviously not aware
of.

What about just removing the workaround ? or is there any pattern that
would make this workaround more selective ?
 

Rgds
Erwan10