[vlc-devel] commit: Fix an actual error path for realloc() that doesn't leak in rtsp/ real.c (JP Dinger )

Rémi Denis-Courmont remi at remlab.net
Tue Jul 14 14:24:10 CEST 2009


On Tue, 14 Jul 2009 14:15:47 +0200, jpd at videolan.org wrote:
> On Tue, Jul 14, 2009 at 01:34:37PM +0200, R??mi Denis-Courmont wrote:
>> Oy. Leading underscores are reserved by the C standard for the
>> "implementation" (i.e. compiler and run-time). We even have on open
> ticket
>> on this. Please do not add MORE of them.
> 
> Force of (c++) habit (cf. namespaces and mangling), fixed.
> 
> Rename the thing vlc_alloc() and put it in a header for de-politising
> the realloc() issue?

Well as much as we can work around realloc() -unlikely- shrinking failure,
we cannot work around -more likely- expansion failures in a generic way.
Since a realloc() wrapper would not know the current size of the
allocation, I fail to see any use thereof.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list