[vlc-devel] [PATCH] libvlc API: Add equalizer to audio.c

[Cyril MATHE]

Le vendredi 10 juillet 2009 à 11:02 -0700, Pierre d'Herbemont a écrit :
Hello,

Sorry for the late....

> Why "config" in libvlc_audio_eqz_config_t?
Because there is two structures, libvlc_audio_eqz_t which have bands
values, preamp value, band number..., and the libvlc_audio_eqz_config_t
which contain the libvlc_audio_eqz_t structure and options for the
setters and getters : enable/disable equalizer, set/get a band value,
set/get an equalizer preset.
> Can this structure be made private?
No.
> Why libvlc_audio_get_eqz() doesn't return directly a pointer to be in
> line with the other getter?
Because libvlc_audio_eqz_config_t has a libvlc_audio_eqz_t structure,
and I thought it is better to return equalizer values in it, instead of
return directly a pointer forcing user to create two structures, one to
get equalizer values and an other one to give option to the getter.

Best Regards
	Cyril