[vlc-devel] commit: itml: no need to set to NULL after the free here. ( Rémi Duraffort )

git version control git at videolan.org
Wed Jul 15 14:41:33 CEST 2009


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Wed Jul 15 14:23:54 2009 +0200| [6798f250a4a607cebe3016409573df0498a292b5] | committer: Rémi Duraffort 

itml: no need to set to NULL after the free here.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6798f250a4a607cebe3016409573df0498a292b5
---

 modules/demux/playlist/itml.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/demux/playlist/itml.c b/modules/demux/playlist/itml.c
index af8d51a..3592f98 100644
--- a/modules/demux/playlist/itml.c
+++ b/modules/demux/playlist/itml.c
@@ -144,7 +144,8 @@ static bool parse_plist_node COMPLEX_INTERFACE
         if( !psz_name || !psz_value )
         {
             msg_Err( p_demux, "invalid xml stream @ <plist>" );
-            FREE_ATT();
+            free( psz_name );
+            free( psz_value );
             return false;
         }
         /* attribute: version */
@@ -158,8 +159,10 @@ static bool parse_plist_node COMPLEX_INTERFACE
         else
             msg_Warn( p_demux, "invalid <plist> attribute:\"%s\"", psz_name);
 
-        FREE_ATT();
+        free( psz_name );
+        free( psz_value );
     }
+
     /* attribute version is mandatory !!! */
     if( !b_version_found )
         msg_Warn( p_demux, "<plist> requires \"version\" attribute" );




More information about the vlc-devel mailing list