[vlc-devel] [PATCH] libvlc : handle VLM input events

jpd at videolan.org jpd at videolan.org
Fri Jul 17 12:11:53 CEST 2009


On Thu, Jul 16, 2009 at 10:01:37AM +0200, S?bastien Escudier wrote:
> Quoting jpd at videolan.org:
> > I'd like an idea of what it should fix, please.
> 
> It adds support of events introduced in this patch :
> 31b1e9090bf4fd386aaca681835b4d4332943c72

Then somebody with vlm architecture clue might take a look. A bit of
discussion over here with jpsaman didn't show a clear need to do it
this way but did raise questions whether and if so how to do it.


> > Dropping the spacing changes
> 
> It was to be consistent with other switch in VLC code.
> Well, most of them at least.

I disagree with your assessment, but even so and regardless of what
you or I think of the aestetics, they are exactly that: cosmetic, and
should by preference not be mixed with non-cosmetic changes.




More information about the vlc-devel mailing list