[vlc-devel] RE : [PATCH] -- still image (hopefully, a clean solution)

[brezhoneg1]

> 
> Le dimanche 12 juillet 2009 01:37:33 brezhoneg1, vous avez écrit :
> > Still images can now be displayed in vlc1.0, but a few issues still
> > exist.
> > Only the following mrls are regarded as still images :
> >    - vlc file.ext
> >    - vlc fake:///path/image.ext
> > (with ext being bmp, png, jpg, tiff, ... listed in src/misc/image.c)
> 
> I never really figured out why we cannot decode still images with a
normal
> demux, which would have a configured image "time span". I must be
missing
> something... ???


We can do as you describe with the current fake implementation (see new
patch attached).

It is slightly less optimized than the first patch (file:// as a
access_demux) because the file is open twice (once at access level and
once at fake decoder level). But, it still works very fine.

Another solution could be to write a new image demux and move away from
the fake implementation (a fake access_demux + a fake decoder). Is it
really needed ?


> > At the vlc core level, the algorithm first does a search for a
"file"
> > access_demux, then only does a search for a "file" access.
> 
> Yes, that works too. But it adds yet another path lookup on file://,
and
> it is
> artificially limitted to the file scheme.

Yes, for now, it is limited to file.

I have got a longer version that also cares about mime-type as well as
file extensions, and support any prefix (file, http,...). Is there a
need for it ?

Rgds
Erwan10 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-fake-support-file-image-path-image.ext-format-i.patch
Type: application/octet-stream
Size: 1752 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090717/8b884914/attachment.obj>