[vlc-devel] [PATCH] -- skins2: make sure skins is fully initialized before a input is launched

[Rémi Denis-Courmont]

Le vendredi 17 juillet 2009 19:18:04 brezhoneg1, vous avez écrit :
> This patch finishes off the work of having skins2 use a dedicated thread
> for both Linux and win32.
>
> Since some initialization is now done in the "Run" function, the "Open"
> function needs to wait for the Run thread to be ready. Otherwise, a
> video passed in the command line can end up being launched before the
> skins2 interface is ready to accept it. This patch re-uses the qt4
> implementation (same issue, same solution).
>
> Since it deals with thread, mutex, cond_wait and so on, a review can
> still be useful before applying it.

vlc_cond_wait() not in a loop is always an error (the loop can be several 
functions up the stack but it has to be somewhere).

Anyway, I'll add semaphores which should make this particular case much 
easier.

-- 
Rémi Denis-Courmont
http://www.remlab.net/