[vlc-devel] RE :[PATCH] -- still image (hopefully, a clean solution)

[brezhoneg1]

> 
> Le vendredi 17 juillet 2009 19:16:53 brezhoneg1, vous avez écrit :
> > We can do as you describe with the current fake implementation (see
new
> > patch attached).
> 
> It seems like you are creating a demux that does not read the input
stream.
> Does that actually work? Laurent?
> 

Yes, using the fake access_demux as a demux seems to work perfectly. It
basically just computes fake pts out of a --fake-fps parameter and sends
empty blocks on a regular basis. Whether a file is open (access) or not
(access_demux) doesn't make much difference.


> > It is slightly less optimized than the first patch (file:// as a
> > access_demux) because the file is open twice (once at access level
and
> > once at fake decoder level). But, it still works very fine.
> >
> > Another solution could be to write a new image demux and move away
from
> > the fake implementation (a fake access_demux + a fake decoder). Is
it
> > really needed ?
> 
> Nobody would answer why we need to have fake:// at all - so I assume
we
> don't
> need it (except for backward compatibility), in fact.
> 

Yes, as a prefix, fake:// is not useful except maybe (not sure) for
invmem.
In addition, fake parameters such as --fake-file and so on are not
allowed in playlist and libvlc anymore for security reason. This limits
its use.

But the fake implementation (module/access/fake.c and
module/codec/fake.c) has been a clean solution for creating a video out
of a single image. And by  just adding a few lines of code, it can be
used with file://path/image.ext one way( access/image:// ) or another(
access_demux with "file" shortcut ).

Unless somebody has other plans ?

Rgds
Erwan10