[vlc-devel] [PATCH] Mirror video filter

Branko Kokanovic branko.kokanovic at gmail.com
Sun Jul 19 20:02:33 CEST 2009

OK, here is updated version (rebased in git, old attachment can be forget)
* Changed copyright (s/2000-2006/2009)
* Fixed typo in label name
* Mirrors alpha plane too (I started mirror filter from invert.c and
it doesn't inverts alpha plane:), my bad)
* Added support for RV24

Now, some questions:
Considering packed formats: I created video with VLC stream
'transcode{vcodec=UYVY}' and it mirrors nicely (actually, I'm a bit
stumped by this behavior too since I mirror byte for byte and this
format is not 'symmetrical').
I also managed to create RV24 format with 'transcode{vcodec=RV24}' and
it needed tweaking to get it right for vertical mirroring (horizontal
is not problem for any format, obviously). I couldn't create RV32, so
I set that filter is not working with it.
* Is there any docs for RV24/32 and how pixels are packed?
* Is vcodec=UYVY same as YUYV, mentioned by Antoine? If it is, I can
say then that mirror filter is working nicely with packed formats.
* Is there any downloadable video that has these packed formats (YUYV,
RV24, RV32, other packed formats...), since I'm not sure in my methods
for creating those packed formats in VLC and I can't find any such
video on my computer
* Finally, is this filter working for you?:)

> On Sat, Jul 18, 2009, Rémi Denis-Courmont wrote:
>> Looks good but why do you copy the picture and only _then_ mirror it? It would
>> be almost twice faster to mirror the original picture directly into the new
>> one, no?

I based mirror.c on invert.c and it creates new picture. Actually, all
filters create new picture, can I 'in-place' edit pixels from
picture_t * in Filter()?
I didn't see any filter do that, so that's why I didn't do that

greetings, Kokan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adding-mirror-video-filter.patch
Type: text/x-diff
Size: 18718 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090719/cb5c0e03/attachment.patch>

More information about the vlc-devel mailing list