[vlc-devel] [PATCH] Mirror video filter

Branko Kokanovic branko.kokanovic at gmail.com
Thu Jul 23 20:08:47 CEST 2009

Didn't want to send new "version" immediately, to wait for other
comments. Here is, fixed Christophe suggestions. Sorry if I spam with
this constant "versions"

Christophe Mutricy wrote:
> Tiny comments
> On Tue, Jul 21, 09 at 23:03 +0200, Branko Kokanovic wrote:
>> +++ b/modules/video_filter/mirror.c
>> +    add_shortcut( "mirror" )
> That's useless because the module is already called mirror.


>> +            msg_Err( p_filter, "Unsupported input chroma (%4s)",
> I think it needs %4.4s to be on the safe side

I also saw a couple of other video filters make same mistake, it puts
some garbage in std output, I can send a patch with a fix for all video
filters, if there is interest, but I'll wait for merging of this patch

Greetings, Kokan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adding-mirror-video-filter.patch
Type: text/x-patch
Size: 25555 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090723/08cb7879/attachment.bin>

More information about the vlc-devel mailing list