[vlc-devel] commit: postproc: no need to set the flag again as the bug is now fixed ( previous commit). ( Rémi Duraffort )

git version control git at videolan.org
Fri Jul 24 08:56:27 CEST 2009


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Fri Jul 24 08:55:28 2009 +0200| [9a61ec484e32f903927337e5ad0ec8fb9eb103ea] | committer: Rémi Duraffort 

postproc: no need to set the flag again as the bug is now fixed (previous commit).
Also remove an uneeded var_Destroy.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9a61ec484e32f903927337e5ad0ec8fb9eb103ea
---

 modules/video_filter/postproc.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/modules/video_filter/postproc.c b/modules/video_filter/postproc.c
index a583c40..16be580 100644
--- a/modules/video_filter/postproc.c
+++ b/modules/video_filter/postproc.c
@@ -189,12 +189,8 @@ static int OpenPostproc( vlc_object_t *p_this )
     config_ChainParse( p_filter, FILTER_PREFIX, ppsz_filter_options,
                        p_filter->p_cfg );
 
-    var_Create( p_filter, FILTER_PREFIX "q",
-                VLC_VAR_INTEGER | VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT |
-                VLC_VAR_ISCOMMAND );
-    /* For some obscure reason the VLC_VAR_ISCOMMAND isn't taken into account
-       in during var_Create */
-    var_Change( p_filter, FILTER_PREFIX "q", VLC_VAR_SETISCOMMAND, NULL, NULL );
+    var_Create( p_filter, FILTER_PREFIX "q", VLC_VAR_INTEGER |
+                VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
 
     text.psz_string = _("Post processing");
     var_Change( p_filter, FILTER_PREFIX "q", VLC_VAR_SETTEXT, &text, NULL );
@@ -214,7 +210,6 @@ static int OpenPostproc( vlc_object_t *p_this )
         {
             msg_Err( p_filter, "Error while creating post processing mode." );
             free( val.psz_string );
-            var_Destroy( p_filter, FILTER_PREFIX "q" );
             pp_free_context( p_sys->pp_context );
             free( p_sys );
             return VLC_EGENERIC;




More information about the vlc-devel mailing list