[vlc-devel] commit: mozilla: do not ship gui/macosx plugin in Safari webplugin ( Jean-Paul Saman )

git version control git at videolan.org
Fri Jul 24 14:28:35 CEST 2009

vlc | branch: master | Jean-Paul Saman <jpsaman at videolan.org> | Tue Jul 14 11:22:37 2009 +0200| [ad5c6b6fa9e92d1a52b388dcb5cf0db894b34b3b] | committer: Jean-Paul Saman 

mozilla: do not ship gui/macosx plugin in Safari webplugin

It is the main cause for memory leaks of VLC browser plugin for MacOS X. Every time the browser plugin is reloaded, vlc core reloads the plugins which causes all global defined objects to initialize. Since there are objects in libmacosx_plugin.dylib that are supposed to live as long as the application these are never freed. Testing is done with --enable-debug.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ad5c6b6fa9e92d1a52b388dcb5cf0db894b34b3b

 Makefile.am |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index f3ad1e4..5e96041 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1116,6 +1116,7 @@ if BUILD_MOZILLA
 # Create Installer
 	rm -rf "$(top_builddir)/macosx-plugin-instdata/"; true
 	mkdir -p "$(top_builddir)/macosx-plugin-instdata"
+	rm -f "$(top_builddir)/projects/mozilla/VLC Plugin.plugin/Contents/MacOS/modules/libmacosx_plugin.dylib" 
 	cp -R "$(top_builddir)/projects/mozilla/VLC Plugin.plugin" "$(top_builddir)/macosx-plugin-instdata"
 	rm -rf "$(top_builddir)/VLC Internet Plug-In.pkg"

More information about the vlc-devel mailing list