[vlc-devel] commit: skins2: correct skins failing to display a video passed at the command line. ( Erwan Tulou )

Rémi Duraffort ivoire at videolan.org
Fri Jul 24 15:08:37 CEST 2009


>> vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Fri Jul 17 
>> 11:29:02 2009 +0200| [327a0522f3441875102fd9e891c38346e1b4dba4] |  
>> committer: Erwan Tulou
>>
>> skins2: correct skins failing to display a video passed at the command line.
>>
>> skins2 now does some intializations (GUI) in the Run function, and  
>> therefore needs the Open function to wait till the Run thread is  
>> ready. This patch fully copies the qt4 initialization process.
>>
>> -static void Run   ( intf_thread_t * );
>> +static void *Run  ( void * );
>
> This introduced a new warning which is raised to an error on the  
> openSUSE Build System.
>
> src/skin_main.cpp: In function 'void* Run(void*)':
> src/skin_main.cpp:347: warning: control reaches end of non-void function
> [...]
>
> I: Program returns random data in a function
> E: vlc-beta no-return-in-nonvoid-function src/skin_main.cpp:347
Fixed thanks.


-- 
Rémi Duraffort | ivoire



More information about the vlc-devel mailing list