[vlc-devel] [PATCH] GSoC: lua services discovery, take two

Fabio Ritrovato exsephiroth87 at gmail.com
Sat Jul 25 13:51:28 CEST 2009


Hello againg,
I've edited the code with courmisch suggestions..
In reply to pdherbhemont, I'll try to explain better the purpose of
the patches...

The first patch is to expand the functionality of services discovery...
As of now, they are read only entities, there's no way for the user to
interact with them (except for the podcast one, but it doesn't work in
an optimal way...)
ItemPut is used to pass a string to an sd, that parse it and use it in
any way he wants...
For example, you can search something on youtube, and display the
results in the playlist window.
The other 2, ItemGet and ItemDelete, are not used at the moment, but
can be useful in the future (for example in the mtp sd, to manage
songs on the device directly from within vlc...)
As for services_discovery_AddParameterValue(), it's used to easliy
build string to pass to the sd, for example with the qt4 interface,
each parameter and it's possible values are in a drop-down menu, so
the user doesn't need to know the sd sintax, but can just choose...
As for the name, I don't see a great problem; input_item_AddInfo() add
an info to the input item info list, why not
services_discovery_AddParameterValue() to add a parameter and its
values to an sd?
Lastly, playlist_ServiceDiscoveryGetById(); you told me not use id,
but from the playlist window, where this function is used, it's the
only way, as of now, to get the pointer of the sd... j-b told me that
the playlist will be rewritten, so probably this function will not be
needed in the future, it's a temporary solution.

The second patch simply create non cacheable modules, they are needed
to make the scripts loaded by simply putting them in the right folder,
without needing to rebuild the cache.

The third patch is a first attempt to the dialog to create strings to
be passed to sd, it's functional, but not the best...

Fourth and fifth patch are the lua backend for sd, the new functions,
and the first 3 modules...

If there's anything else, let me know...

Best regards,
Fabio Ritrovato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001--GSoC-luasd-expand-services-discovery-functionalit.patch
Type: text/x-diff
Size: 8948 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090725/69ae70f5/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002--GSoC-luasd-create-uncachable-modules.patch
Type: text/x-diff
Size: 3842 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090725/69ae70f5/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003--GSoC-luasd-tentative-interface-to-pass-data-to-sd.patch
Type: text/x-diff
Size: 14427 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090725/69ae70f5/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004--GSoC-luasd-lua-backend.patch
Type: text/x-diff
Size: 20195 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090725/69ae70f5/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005--GSoC-luasd-first-3-scripts-youtube-dailymotion.patch
Type: text/x-diff
Size: 46173 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090725/69ae70f5/attachment-0004.patch>


More information about the vlc-devel mailing list