[vlc-devel] [PATCH] GSoC: lua services discovery, take two

[Pierre d'Herbemont]

On Sat, Jul 25, 2009 at 11:05 AM, Jean-Baptiste Kempf<jb at videolan.org> wrote:
> On Sat, Jul 25, 2009 at 10:54:59AM -0700, Pierre d'Herbemont wrote :
>> On Sat, Jul 25, 2009 at 4:51 AM, Fabio Ritrovato<exsephiroth87 at gmail.com> wrote:
>> > Lastly, playlist_ServiceDiscoveryGetById(); you told me not use id,
>> > but from the playlist window, where this function is used, it's the
>> > only way, as of now, to get the pointer of the sd... j-b told me that
>> > the playlist will be rewritten, so probably this function will not be
>> > needed in the future, it's a temporary solution.
>>
>> Well, the hypothetical playlist rewrite seems to happen gradually.
>
> Well, this function is just used in the qt4 playlist dialog, and I will
> change it quite quickly and after that remove the
> playlist_ServiceDiscoveryGetById().

So if it's only used here, inline it.

>> > services_discovery_AddParameterValue() to add a parameter and its
>> > values to an sd?
>>
>> I am going to be picky, but this parameter API is too obscure and too
>> vague. We don't want that level of flexibility in vlc, at least for
>> the sake of checking.
> Why don't we want such a level of flexibility ?

Because the result is something vague, that does not explicitly tells
what it does, and that you is not checkable.

Pierre.