[vlc-devel] libvlc API: Add equalizer to audio.c

[Pierre d'Herbemont]

On Jul 28, 2009, at 1:39 AM, Rémi Denis-Courmont wrote:

>
> On Tue, 28 Jul 2009 01:02:16 -0700, Pierre d'Herbemont
> <pdherbemont at gmail.com> wrote:
>>>> libvlc_audio_equalizer *  libvlc_audio_equalizer_new(); /*
>>>> eventually ? */
>>> enable equalizer ? shouldn't be: libvlc_audio_equalizer_new(bool
>>> b_enable)
>>
>> No I don't think that's a good approach.
>>
>> The equalizer should be enabled depending on each particular
>> media_player using libvlc_media_player_set_equalizer().
>
> Hmmmmmmm, I agree. But we cannot blame Cyril for the fact that VLC  
> still
> uses a single audio output per instance...


Having only one audio output shouldn't prevent mixing with different  
equalizer, should it?

Else, I believe this would be a bug.

If this is a hard limitation that we are unlikely able to fix, we  
could fallback to libvlc_(get|set)_equalizer(), instead of having a  
broken API implementation... Too bad :(

Pierre.