[vlc-devel] libvlc API: Add equalizer to audio.c

[jpd at videolan.org]

On Tue, Jul 28, 2009 at 09:42:22AM -0700, Pierre d'Herbemont wrote:
> On Jul 31, 2009, at 5:38 AM, Cyril MATHE wrote:
>> bool libvlc_audio_equalizer_get_enable(libvlc_audio_equalizer*)
>> void libvlc_audio_equalizer_set_enable(libvlc_audio_equalizer*, bool
>> b_enable)
>
> This shouldn't be needed. The equalizer should be enabled as soon as
> media_player_set_equalizer(equlizer);
> is called.
>
> I would say:
> 	media_player_set_equalizer(NULL);
> Which could be equivalent to:
> 	media_player_set_equalizer(Libvlc_DisabledEqualizer);
>
> to disable it from a specified instance.

I don't disagree but I wonder if it wouldn't be more interesting to
make equalizer a filter so that you can put multiple in a chain if
you have to. Say, one before transcoding and one after.