[vlc-devel] commit: raop: Always read headers from wire (Michael Hanselmann )

git version control git at videolan.org
Wed Jul 29 18:18:45 CEST 2009


vlc | branch: master | Michael Hanselmann <public at hansmi.ch> | Wed Jul 22 01:06:42 2009 +0200| [08c47fec290813dad0e610b813dd62f3fce41c43] | committer: Rémi Denis-Courmont 

raop: Always read headers from wire

Otherwise they can be mixed up with the next request. Until now, the
connection was always terminated after an error. However, with
authentication, the request can be repeated with authentication
information.

Signed-off-by: Michael Hanselmann <public at hansmi.ch>
Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=08c47fec290813dad0e610b813dd62f3fce41c43
---

 modules/stream_out/raop.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/modules/stream_out/raop.c b/modules/stream_out/raop.c
index 96579ee..24771b9 100644
--- a/modules/stream_out/raop.c
+++ b/modules/stream_out/raop.c
@@ -810,14 +810,6 @@ static int ExecRequest( vlc_object_t *p_this, const char *psz_method,
         goto error;
     }
 
-    if ( i_status != 200 )
-    {
-        msg_Err( p_this, "Request failed (%s), status is %d",
-                 p_sys->psz_last_status_line, i_status );
-        i_err = VLC_EGENERIC;
-        goto error;
-    }
-
     if ( p_resp_headers )
         vlc_dictionary_clear( p_resp_headers, FreeHeader, NULL );
 
@@ -830,6 +822,14 @@ static int ExecRequest( vlc_object_t *p_this, const char *psz_method,
             goto error;
     }
 
+    if ( i_status != 200 )
+    {
+        msg_Err( p_this, "Request failed (%s), status is %d",
+                 p_sys->psz_last_status_line, i_status );
+        i_err = VLC_EGENERIC;
+        goto error;
+    }
+
 error:
     FREENULL( p_sys->psz_last_status_line );
 




More information about the vlc-devel mailing list