[vlc-devel] [PATCH] Solve a pause behaviour problem in fake access/demux
remi at remlab.net
Thu Jul 30 16:45:32 CEST 2009
Le jeudi 30 juillet 2009 15:13:25 Hugo Beauzee-Luyssen, vous avez écrit :
> There's a potential error source inside of the fake access/demux :
> When the media player is paused, the `Control` function stores the
> current pts, and uses it to compute the pause duration.
> If using --no-skip-frames, this can be a problem, making the pause
> twice as long as intended. This patch corrects it.
config_GetInt() is wrong, as the input item might override the configuration
value. var_CreateGetInteger() would be wrong, as it would create a new
variable, hence preventing a later change of the variable on the input item
from propagating. var_GetInteger() would not work as the variable does not
exist on the demux object.
So... I'm afraid accessing the skip-frame variable that way cannot work
properly. Maybe the logic should be entirely rewritten??
More information about the vlc-devel