[vlc-devel] [PATCH 2/2] Made VLCKit's VLCOpenGLVoutView ignore -reshape requests when quit is in progress, thus avoiding a segfault.

Malte Tancred malte at frontbase.com
Mon Jun 1 09:25:37 CEST 2009


On 30 maj 2009, at 13.28, Derk-Jan Hartman wrote:
> Hmm, and setting nil fixes those crashes for you ? Interesting. I  
> have seen similar crashes on the crashreports list. I guess we will  
> go wild with the nil's. It can also mean that the refcounting just  
> messes up somewhere....

Actually no, setting those variables to nil didn't stop the crash. But  
it's good form resetting an object pointer after sending the object a  
release message. I suspect, but haven't investigated thoroughly, that  
p_vout->p_sys->o_glview is a player in the segfault I see.

What fixed the crash was checking p_vout->b_die in the -reshape method.

Regards,
Malte




More information about the vlc-devel mailing list