[vlc-devel] TR : [PATCH] -- skins2: workaround to possible hangings with xlib
remi at remlab.net
Mon Jun 1 12:22:28 CEST 2009
On Mon, 1 Jun 2009 11:32:23 +0200, "brezhoneg1" <brezhoneg1 at yahoo.fr>
> Are there any problems that prevent from applying this patch?
Yes, there are.
First, the skins2 maintainer have essentially left the project.
Secondly, I do not understand the original code - why is it mapping and
immediately un-mapping the same window?!
Thirdly, in my understand of Xlib, your patch introduces a busy loop. This
is not unlikely to fail if the skins2 task is simply too fast compared to
the X server.
Why don't just remove the dummy map/un-map sequence?
> I do admit this is an easy workaround that don't solve the underlying
> problem (a design issue with xlib).
As much as I dislike xlib, not every VLC X11 bug is Xlib's fault. If I
understand correctly, the dialog provider share a lot of code with the
former interaction framework. I know very well how buggy and poorly
designed that framework was. Therefore, I am very suspicious of the dialog
> But, at least, on Debian5.0 and probably others, skins2 can really be
> used satisfactorily with this patch, whereas it is a frustrating
> experience without it (too many hangings).
> Since a skins2 contest is taking place, I would guess shipping vlc
> with this patch could be appreciated by the skins2 community testing
> their brand-new skins?
As JB hinted, the few Linux users we still have are probably using Qt4 or
Wx, not skins2 because it's been so crap for so long.
More information about the vlc-devel