[vlc-devel] commit: Patch: Fix pulseaudio clicking and latency issues (Danny Wood )

[Nicolas Chauvet]

2009/5/10 git version control <git at videolan.org>:
> vlc | branch: 1.0-bugfix | Danny Wood <danwood76 at gmail.com> | Sat May  9 11:05:31 2009 +0100| [b8f23ea716693d8d07dd8bd0cb4c9ba8ed05f568] | committer: Rémi Denis-Courmont
>
> Patch: Fix pulseaudio clicking and latency issues
>
> Here is the updated patch with the modified configure.ac.
> I have also added some comments and cleaned up a little bit of code.
>
> Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b8f23ea716693d8d07dd8bd0cb4c9ba8ed05f568
> ---
>
>  configure.ac                 |    2 +-
>  modules/audio_output/pulse.c |   28 +++++++++++-----------------
>  2 files changed, 12 insertions(+), 18 deletions(-)
This patch broke the PA output in my case.
Even if pulseaudio is > 0.9.11 (It is 0.9.14 here) the PA output is then broken.

That regression was initially reported there:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=635

The PA output seems to initialize well, despite no sound is heard.
It can be seen with the PA Volume Control where the stream is
connected to the PA daemon.
Everything is fine WRT others multimedia players.
Once the b8f23ea716693d8d07dd8bd0cb4c9ba8ed05f568 commit is reverted,
the vlc module works again with its native pulseaudio output.

Nicolas (kwizart)

PS:  Please reminds that when testing the PA output on a system that
is capable of building the module, the PA output needs to be
explicitely choosen.