[vlc-devel] [PATCH] contribs: compile x264 and live555 as PIC

[Kaloyan Kovachev]

On Fri, 5 Jun 2009 11:29:55 +0200, Pierre Ynard wrote
> Compile x264 and live555 as PIC, as otherwise it causes linkage problems
> on 64 bits
> 
> diff --git a/extras/contrib/src/Makefile b/extras/contrib/src/Makefile
> index 223df26..9cc78b9 100644
> --- a/extras/contrib/src/Makefile
> +++ b/extras/contrib/src/Makefile
> @@ -166,6 +166,10 @@ ifdef HAVE_AMR
>  FFMPEGCONF+= --enable-libamr-nb --enable-libamr-wb --enable-nonfree
>  endif
> 
> +ifdef HAVE_LINUX
> +X264CONF += --enable-pic
> +endif
> +

isn't it better to have:

+ifeq ($(ARCH),x86_64)
+X264CONF += --enable-pic
+endif
+

and there is one more around line 1425

>  DATE=`date +%Y-%m-%d`
> 
>  # ***************************************************************************
> @@ -1292,6 +1296,7 @@ ifdef HAVE_BIGENDIAN
>  	(cd $<; ./genMakefiles armeb-uclibc && make $(HOSTCC))
>  endif
>  else
> +	(cd $<; sed -e 's%-D_FILE_OFFSET_BITS=64%-D_FILE_OFFSET_BITS=64\ -fPIC\
-DPIC%' -i.orig config.linux)

+ifeq ($(ARCH),x86_64) here too ... not sure if it may brake something on
32bit, but ...

for ffmpeg "--enable-shared" is also needed and probably "--enable-pthreads"
could also be added for the ffmpeg-mt version, but thats different story

>  	(cd $<; ./genMakefiles linux && make $(HOSTCC))
>  endif
>  endif
> 
> Regards,
> 
> -- 
> Pierre Ynard
> "Une вme dans un corps, c'est comme un dessin sur une feuille de papier."
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel