[vlc-devel] RE : [PATCH] -- multiple snapshots taken from menus(correct trac #2818)

[Rémi Denis-Courmont]

Le vendredi 5 juin 2009 17:16:08 brezhoneg1, vous avez écrit :
> > Le vendredi 5 juin 2009 11:50:31 brezhoneg1, vous avez écrit :
> > > See trac #2818 for details
> > >
> > > This patch is based on 1.0-bugfix, and is needed for both 1.0-bugfix
>
> and
>
> > > master reps.
> >
> > Does that not mean we are leaking menus all the time... ?
>
> Well, not a memory leak, but connecting the same signal to the same slot
> over and over is cumulative.
>
> I tested it for snapshot and for scaling. First access to the menu gives
> 1 call to the callback, 2n access two calls, third access three calls,
> ....
>
> For some functions as scaling, it goes unnoticed. For others like
> snapshot, some buggy effects can occur.

Merged. Thanks for the patch and clarification.

-- 
Rémi Denis-Courmont
http://www.remlab.net/