[vlc-devel] commit: libvlc: Don't use enum directly, it's a?bad pratice for ABI compat. (Pierre d'Herbemont )
fenrir at via.ecp.fr
Wed Jun 10 19:27:11 CEST 2009
On Wed, Jun 10, 2009, Rémi Denis-Courmont wrote:
> Le mercredi 10 juin 2009 20:10:36 Laurent Aimar, vous avez écrit :
> > On Tue, Jun 09, 2009, git version control wrote:
> > > vlc | branch: 1.0-bugfix | Pierre d'Herbemont <pdherbemont at free.fr> | Mon
> > > May 25 03:42:10 2009 -0700| [59c79c740cf3517b7fa96ebd0e4f98d950352102] |
> > > committer: Pierre d'Herbemont
> > >
> > > libvlc: Don't use enum directly, it's a bad pratice for ABI compat.
> > Are you sure that this change does not break the ABI ?
> > (I think there is other enum change like that one) ?
> That depends on the calling convention.
Didn't know this one.
> In other words, it does break the ABI.
I was more thinking about the fact that enum can be stored as an
int, unsigned int or a unsigned(?) char at the compilator convenience,
unless I am wrong. And so it might break all structures using it.
More information about the vlc-devel