[vlc-devel] RE : [PATCH] -- correct broken URI for Windows(trac#2843)

[brezhoneg1]

> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Rémi Denis-Courmont
> Envoyé : jeudi 11 juin 2009 09:17
> À : Mailing list for VLC media player developers
> Objet : Re: [vlc-devel] [PATCH] -- correct broken URI for
> Windows(trac#2843)
> Importance : Faible
> 
> 
> On Thu, 11 Jun 2009 00:38:27 +0200, "brezhoneg1" <brezhoneg1 at yahoo.fr>
> wrote:
> > This patch corrects URI handling for Windows, which has been
preventing
> > xspf from working on both 1.0-bugfix and master for some time.
> >
> > The patch does assume a Windows URI is in the form of
> > /C:/path/to/file/file.ext
> >
> > - decode_URI : the extra / at the beginning of the URI must be
removed
> > at decoding time
> 
> Removing characters is not the job of decode_URI. Go read the spec
(the
> reference is in the code... for a reason). I can reject this patch
even
> before I read it.
> 

The patch may not be okay, but there is no need to downgrade this email
to low priority ... A real problem exists for Windows right now (xspf is
broken, and hence media library) that is quite a regression.

Was the extra / inserted in make_URI for Windows just a typo or a
decision to really have path in the form
file:///C:/path/to/file/file.ext ?
(the extra / seems to be optional from reading from the web)

Erwan10