[vlc-devel] [PATCH] UI: spref_audio menu fixes and enhancements

Jean-Baptiste Kempf jb at videolan.org
Thu Jun 11 13:35:35 CEST 2009


On Thu, Jun 11, 2009 at 01:28:05PM +0200, Francois Cartegnie wrote :
> +    /* see remark below */
> +    ((QCheckBox *) qwidget)->setChecked( p_item->value.i == true );
No. Use qobject_cast.

> +        should user-redefine checkbox & radio class with a common interface
hmm, QAbstractButton ?

> +#include <QRadioButton>
class QRadioButton is enough.

Else, patch seems ok.

-- 
jb



More information about the vlc-devel mailing list