[vlc-devel] [PATCH] SQL Media Library

Jean-Philippe André helkanen at gmail.com
Fri Jun 12 06:12:57 CEST 2009


2009/6/12 Barry Wardell <barry.wardell at gmail.com>

> Hi,
>  Well applying non clean code is really a bad idea in the long run.
>> I would really prefer that the code is reviewed and then applied if clean,
>> especially with new module API.
>>  As a general remark, the patchs used way too much defines where simple
>> functions
>> or inlines functions would be cleaner and safer.
>>  Adding doxygen comment to vlc_sql.h is also needed (at least).
>>  I can propose myself to review the patchs once the above remarks are
>> corrected if you want.
> I'm just wondering what the current status on this is? I noticed that there
> were some commits to vlc-ecp-project.git subsequent to this which look like
> they were trying to address the issues raised.
> I am asking mainly because I would like to use the media library for my
> GSoC project (media center interface) so am wondering what the best way to
> use it would be. If the code is going to be merged soon, then it would be
> easiest to merge those changes from master into my branch. Otherwise, I'll
> probably just use apply the patches to my own branch for now.

Thanks for your interest. As I'm already working with my GSoC students, I
don't have that much time to spend on this project now. I still want to
clean it and send the patches again asap. Srikanth Raju a.k.a. jetru is
working on the GSoC project for the ML.

jetru created some "bugfix" branch for the ML patches in his Git repo
(vlc-jetru.git). You may want to have a look at the state of the ML there as
I won't update vlc-ecp-project anymore.

I think the best is that you contact me directly on IRC or mail, with Cc: to

Best regards,

Jean-Philippe André
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090612/abb1258a/attachment.html>

More information about the vlc-devel mailing list