[vlc-devel] [PATCH] libgoom_plugin.dll mem leak patch

Rémi Denis-Courmont remi at remlab.net
Fri Jun 12 08:56:13 CEST 2009


On Thu, 11 Jun 2009 22:12:47 +0100, Michael McEll <mapei_ at hotmail.com>
> Here is a
> patch for vlc/modules/visualization/goom.c which works around the the
> failings of libgoom2k4 ability to free its resources.
> Instead of creating a new instance of libgoom2k4 on each track start,
> this patch a single instance will be used throughout.

Is this problem really Win32-specific? What about a static lock and
reference counter in Open/Close function. Also, with your patch libgoom
will be initialized whenever the module is loaded, including when
enumerating or when probing the module (but not actually using it)...

Rémi Denis-Courmont

More information about the vlc-devel mailing list