[vlc-devel] [PATCH] Enable aspectratio parameter in mozillaplugin

[Rémi Denis-Courmont]

On Fri, 12 Jun 2009 09:26:55 +0200, jpd at videolan.org wrote:
> On Fri, Jun 12, 2009 at 09:02:23AM +0200, R??mi Denis-Courmont wrote:
>> This is a generic problem with libvlc vout handling (and aout also).
>>
>> IMHO, instead of looking for any single vout, it should:
>>  - Apply the setting to all existing vouts for the input,
>>  - Store the setting in the appropriate input variable for later vouts,
>>  - Not return an exception when there are no vouts.
>>
>> This would ensure that the API works regardless of the number of
>> outputs and make it a less racy and easier to use. I've been meaning
>> to do this in 1.1, but I haven't had time this far. Help welcome.
> 
> I believe Sigmund was looking for such a thing recently, if for
> different settings (screen positioning). I don't know much about vouts,
> so some questions:
> 
> - Does this need an extra layer, or is there already an appropriate
>   place to do this? Setting a configuration variable means it'll persist
>   to the next run, too, which may be overkill or even not what is
>   desired at all.

This should be set on the input object anyway. This does not change the
scope of the setting, it just makes it easier/more consistent to use.

-- 
Rémi Denis-Courmont